mirror of
https://github.com/stargieg/bacnet-stack
synced 2025-10-26 23:35:52 +08:00
17058b23b3
When a packet is received which expects a reply a copy is stored in the PDU ring buffer so it can be matched with the reply. Unfortunately when the reply is received it is only checked against the first entry in the ring buffer. This can cause a failure if a second packet expecting a reply has been received while waiting for the first reply to arrive.
This is a known issue in the bacnet-stack open source stack, and there is a outstanding FIXME in the latest version of the source code:
/* The ANSWER_DATA_REQUEST state is entered when a */
/* BACnet Data Expecting Reply, a Test_Request, or */
/* a proprietary frame that expects a reply is received. */
/* FIXME: MSTP_Get_Reply waits for a matching reply, but
if the next queued message doesn't match, then we
sit here for Treply_delay doing nothing */
The fix for this is to check all the messages in the PDU queue to see if any of them match, and if one does then handle it in the normal way. Thank you to Ian Smith of Abelon Systems Ltd. for the patch!
|
||
|---|---|---|
| .. | ||
| arcnet.c | ||
| bacnet_ipv6.lua | ||
| bacsec_linux.c | ||
| bip-init.c | ||
| bip6.c | ||
| dlmstp_linux.c | ||
| dlmstp_linux.h | ||
| dlmstp.c | ||
| dlmstp.mak | ||
| ethernet.c | ||
| mstpsnap.c | ||
| mstpsnap.mak | ||
| net.h | ||
| readme.txt | ||
| rs485.c | ||
| rs485.h | ||
| rs485.mak | ||
| rx_fsm.c | ||
| rx_fsm.mak | ||
| timer.c | ||
| timer.h | ||
This is a port to Linux for testing. The unit tests can be run via the test.sh script.