mirror/otto
1
0
Fork 0
mirror of https://github.com/robertkrimen/otto synced 2025-09-28 18:45:22 +08:00
Code Issues Releases Wiki Activity

Adjusted commentary on evaluateIdentifier

Browse Source
This commit is contained in:
Robert Krimen 2012-10-09 17:49:33 -07:00
parent 0134729b74
commit a31375b07b
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
evaluate_expression.go
View File

@ -522,11 +522,12 @@ func (self *_runtime) evaluateBracketMember(node *_bracketMemberNode) Value {
func (self *_runtime) evaluateIdentifier(node *_identifierNode) Value { func (self *_runtime) evaluateIdentifier(node *_identifierNode) Value {
name := node.Value name := node.Value
// TODO Should be true or false (strictness) depending on context // TODO Should be true or false (strictness) depending on context
// TODO Associate the node with reference... how? // getIdentifierReference should not return nil, but we check anyway and panic
// TODO Can/Will getIdentifierReference ever return nil? // so as not to propagate the nil into something else
reference := getIdentifierReference(self.LexicalEnvironment(), name, false, node) reference := getIdentifierReference(self.LexicalEnvironment(), name, false, node)
if reference == nil { if reference == nil {
panic("referenceError: " + name) // Should never get here!
panic(hereBeDragons("referenceError == nil: " + name))
} }
return toValue(reference) return toValue(reference)
} }