mirror/otto
1
0
Fork 0
mirror of https://github.com/robertkrimen/otto synced 2025-10-12 20:27:30 +08:00
Code Issues Releases Wiki Activity

RegExp(/xyzzy/) & RegExp(/xyzzy/, undefined) will return a reference to the exact same /xyzzy/ object...

Browse Source 
...instead of creating a new copy
This commit is contained in:
Robert Krimen 2013-05-02 20:23:06 +02:00
parent 1628647e05
commit de97589c43
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
builtin_regexp.go
View File

@ -7,7 +7,14 @@ import (
// RegExp
func builtinRegExp(call FunctionCall) Value {
return toValue(call.runtime.newRegExp(call.Argument(0), call.Argument(1)))
pattern := call.Argument(0)
flags := call.Argument(1)
if object := pattern._object(); object != nil {
if object.class == "RegExp" && flags.IsUndefined() {
return pattern
}
}
return toValue(call.runtime.newRegExp(pattern, flags))
}
func builtinNewRegExp(self *_object, _ Value, argumentList []Value) Value {

12
regexp_test.go
View File

@ -121,6 +121,18 @@ func TestRegExp_zaacbbbcac(t *testing.T) {
}
}
func TestRegExpCopying(t *testing.T) {
Terst(t)
test := runTest()
test(`
abc = /xyzzy/i;
def = RegExp(abc);
abc.indicator = 1;
[ abc.indicator, def.indicator ];
`, "1,1")
}
func TestRegExp_multiline(t *testing.T) {
Terst(t)