mirror/otto
1
0
Fork 0
mirror of https://github.com/robertkrimen/otto synced 2025-10-12 20:27:30 +08:00
Code Issues Releases Wiki Activity

Remove cruft from arguments

Browse Source
This commit is contained in:
Robert Krimen 2013-02-25 13:34:37 -08:00
parent c5f05dd873
commit fc55f7c7d9
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
runtime.go
View File

@ -121,6 +121,11 @@ func (self *_runtime) PutValue(reference _reference, value Value) {
func (self *_runtime) _callNode(environment *_functionEnvironment, node *_functionNode, this Value, argumentList []Value) Value {
indexOfParameterName := make([]string, len(node.ParameterList))
// function(abc, def, ghi)
// indexOfParameterName[0] = "abc"
// indexOfParameterName[1] = "def"
// indexOfParameterName[2] = "ghi"
// ...
for index, name := range node.ParameterList {
value := UndefinedValue()

17
type_arguments.go
View File

@ -7,17 +7,7 @@ import (
func (runtime *_runtime) newArgumentsObject(indexOfParameterName []string, environment _environment, length int) *_object {
self := runtime.newClassObject("Arguments")
self.prototype = runtime.Global.ObjectPrototype
self.stash = newArgumentsStash(indexOfParameterName, environment, self.stash)
//for index, value := range argumentList {
// // TODO Write test for runtime.GetValue(value)
// // The problem here is possible reference nesting, is this the right place to GetValue?
// // FIXME This is sort of hack-y
// // 2012-02-23:
// // Not using this because we arguments should not be configurable (i.e. DontDelete)
// // self.set(arrayIndexToString(uint(index)), runtime.GetValue(value), false)
// self.stash.set(arrayIndexToString(uint(index)), runtime.GetValue(value), 0110)
//}
self.stash.set("length", toValue(length), 0101)
return self
@ -25,7 +15,12 @@ func (runtime *_runtime) newArgumentsObject(indexOfParameterName []string, envir
type _argumentsStash struct {
indexOfParameterName []string
environment _environment
// function(abc, def, ghi)
// indexOfParameterName[0] = "abc"
// indexOfParameterName[1] = "def"
// indexOfParameterName[2] = "ghi"
// ...
environment _environment
_stash
}