mirror/bacnet-stack
1
0
Fork 0
mirror of https://github.com/stargieg/bacnet-stack synced 2025-10-26 23:35:52 +08:00
Code Issues Releases Wiki Activity
169 Commits 1 Branch 0 Tags 3.5 MiB
17058b23b3
Commit Graph

27 Commits

Author SHA1 Message Date
Steve Karg
17058b23b3 [r3137] Adds two new functions to the ring buffer implementation, one to walk the ring by getting a pointer to the next element in the ring, and the other to Pop (remove) a specified element from somewhere in the ring and then move any elements up towards the head to fill the gap left. With these new functions in place, the Linux MS/TP datalink MSTP_Get_Reply() has been updated to walk the ring buffer to try to find the matching reply. If it is found then it is processed in the same way as usual, and then removed from the ring. 
When a packet is received which expects a reply a copy is stored in the PDU ring buffer so it can be matched with the reply. Unfortunately when the reply is received it is only checked against the first entry in the ring buffer. This can cause a failure if a second packet expecting a reply has been received while waiting for the first reply to arrive.
This is a known issue in the bacnet-stack open source stack, and there is a outstanding FIXME in the latest version of the source code:

        /* The ANSWER_DATA_REQUEST state is entered when a  */
        /* BACnet Data Expecting Reply, a Test_Request, or  */
        /* a proprietary frame that expects a reply is received. */
        /* FIXME: MSTP_Get_Reply waits for a matching reply, but
           if the next queued message doesn't match, then we
           sit here for Treply_delay doing nothing */

The fix for this is to check all the messages in the PDU queue to see if any of them match, and if one does then handle it in the normal way. Thank you to Ian Smith of Abelon Systems Ltd. for the patch!
 2018-03-25 15:59:10 +02:00
Steve Karg
d33bec7472 [r3133] Fixed MS/TP ANSWER_DATA_REQUEST state in some of the ports to be compliant to the standard by emitting Reply-Postponed rather than nothing when the data request times out. 2018-03-25 15:57:20 +02:00
Patrick Grimm
d4767d3e61 add default if en0 2017-04-08 22:36:54 +02:00
Patrick Grimm
af359c7d88 copy ports/linux/bip6.c ports/bsd/bip6.c 2017-04-08 22:20:21 +02:00
Steve Karg
93aac61ff7 [r3117] Changes to clean up compile warnings 2017-04-05 22:11:31 +02:00
Patrick Grimm
233ff85d6e revert 2783bf85b4 fix compiler warning make get_local_address_ioctl static 2017-04-05 21:48:06 +02:00
Steve Karg
447a18383d [r3109] Updated Atmega8 project to compile under IAR EWARM 6.40.3 2017-04-05 00:17:57 +02:00
Steve Karg
ab7db70c0b [r3103] Merged revision(s) 3102 from branches/releases/bacnet-stack-0-8-0: 
Changed info prints to go to stdout rather than stderr to clean up Wireshark extcap usage.
........
 2017-04-05 00:04:43 +02:00
Steve Karg
1c2f5fe982 [r3098] Fixed [bug#40] - problems if pdu_len exceeds the size of a single pbuf block. Thank you, Jörg Hofmann! 
Added statistics to track packets sent, received, and errors.
Added proper reply when BVLC functions are requested and not supported.
Fixed Forwarded NPDU.
 2017-04-05 00:03:12 +02:00
Steve Karg
28247f5e98 [r3097] Added MS/TP slave node to BDK DLMSTP module. 2017-04-05 00:02:49 +02:00
Steve Karg
ea88ee7bd4 [r3075] Removed extra RS485 init from main in STM32 port example. Thank you, Sean Monroe! 2017-04-04 19:46:43 +02:00
Steve Karg
e43e2afb93 [r3073] Removed extra LED init from main in STM32 port example. Thank you, Sean Monroe! 2017-04-04 19:46:43 +02:00
Steve Karg
6d794d856f [r3071] Adjusted device object local variables in PIC demo to build successfully within given stack frame. 2017-04-04 19:46:43 +02:00
Patrick Grimm
fe71b73ba1 fix compile issue with musl libc 2016-12-10 10:43:36 +01:00
Patrick Grimm
d6dea9fbd5 [r3066] Added Wireshark 2.x extcap live capture for mstpcap on Linux. 
Author: skarg@r3066
 2016-11-01 19:29:15 +01:00
Patrick Grimm
b167b6293e [r3060] Some Win32 changes for clean compile of IPv6. 
Author: skarg@r3060
 2016-11-01 19:23:29 +01:00
Patrick Grimm
4cfd94b27a [r3059] Fixed ports for Atmega8, Atmega168, and Xmega to compile. 
Author: skarg@r3059
 2016-11-01 19:22:01 +01:00
Patrick Grimm
9b6af087df [r3058] Changed Device_Object_List_Identifier() to use uint32_t for array_index since that is the size decoded in a ReadProperty request, and unsigned is not always 32-bit. \n Author: skarg@r3058 2016-11-01 03:32:21 +01:00
Patrick Grimm
1b4cb0eee5 update add compile switch for bac objects ai,ao,.. 2016-10-30 23:48:37 +01:00
Patrick Grimm
dffc351abe cleanup 2016-10-30 23:23:46 +01:00
Patrick Grimm
2783bf85b4 fix compiler warning make get_local_address_ioctl static 2016-10-30 23:21:31 +01:00
Patrick Grimm
8537627650 change ipv6 broadcast from BIP6_MULTICAST_SITE_LOCAL to BIP6_MULTICAST_GLOBAL interop with yabe 2016-10-30 23:19:30 +01:00
Patrick Grimm
b9bb161ade update to r3056 from https://sourceforge.net/p/bacnet/code/3056/tree/trunk/bacnet-stack/ add ipv6 and schedule support 2016-10-30 16:16:03 +01:00
Patrick Grimm
83f431d1e4 add #if PRINT_ENABLED for printf() 2014-02-21 20:34:09 +01:00
Patrick Grimm
be9160c7d1 rename ms-input to msi 2013-09-23 03:15:18 +02:00
Patrick Grimm
f86501a108 fix gcc warnings, define function Prototyp 2013-04-12 07:39:47 +02:00
Patrick Grimm
01349ec9e8 fork from http://sourceforge.net/projects/bacnet/ 2013-03-21 22:53:31 +01:00